Use page associations to get routes#2273
Merged
Merged
Conversation
stephencdaly
force-pushed
the
use-page-associations-to-get-routes
branch
4 times, most recently
from
6765a8d to
2c3ba8b
Compare
lfdebrux
reviewed
Oct 9, 2025
stephencdaly
force-pushed
the
use-page-associations-to-get-routes
branch
from
2c3ba8b to
bae0b43
Compare
lfdebrux
approved these changes
Oct 9, 2025
lfdebrux
left a comment
lfdebrux
left a comment
Contributor
There was a problem hiding this comment.
Yay for fewer services! Thanks for doing this
Previously conditions were retrieved from forms-api and returned as part of the Form response. Now they are stored in the forms-admin database, so we can use ActiveRecord associations to get them directly for a given page and reduce the number of SQL queries executed.
Add a method to get the secondary skip condition for a page if one exists and use this in the places we were previously using PageRoutesService to simplify how we retrieve the condition.
PageRoutesService and PageConditionsService are no longer used so can be deleted.
Previously, we had to reload the pages after adding conditions as we were mocking out the method for retrieving them. Now that conditions are retreived from the database, these reloads are unnecessary in request specs as the code under test will retrieve the latest data from the database.
stephencdaly
force-pushed
the
use-page-associations-to-get-routes
branch
from
bae0b43 to
2de90a5
Compare
|
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2273.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Previously conditions were retrieved from forms-api and returned as part of the Form response. Now they are stored in the forms-admin database, so we can use ActiveRecord associations to get them directly for a given page and reduce the number of SQL queries executed.
This means we can remove
PageConditionsServiceandPageRoutesService.Things to consider when reviewing